Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bash completion regression #772

Merged
merged 2 commits into from
Oct 18, 2016
Merged

Fix bash completion regression #772

merged 2 commits into from
Oct 18, 2016

Conversation

zachriggle
Copy link
Member

Fixes #767

@zachriggle
Copy link
Member Author

@idolf I still can't get the old version to work, but this should at least put things back the way they were before 66e41bd and account for new changes

@TethysSvensson
Copy link
Contributor

LGTM. I will do a backport to beta and perhaps stable once you merge it.

@zachriggle zachriggle changed the base branch from dev to beta October 17, 2016 20:44
@zachriggle
Copy link
Member Author

Retargeted to beta to ease backports. Doesn't need to go to stable.

@zachriggle
Copy link
Member Author

This is failing on the Github checks. #761 needs to be backported first.

@TethysSvensson TethysSvensson added this to the 3.2.0 milestone Oct 18, 2016
@TethysSvensson TethysSvensson merged commit 7695acc into Gallopsled:beta Oct 18, 2016
@zachriggle zachriggle added the bug label Dec 14, 2016
@zachriggle zachriggle modified the milestones: 3.3.0, 3.2.0 Dec 14, 2016
@zachriggle zachriggle deleted the bash-completion-fix branch January 4, 2017 18:03
@zachriggle
Copy link
Member Author

This really landed in 3.2

$ git tag --contains 7695acc | sort -V | head -1
3.2.0

@zachriggle zachriggle modified the milestones: 3.3.0, 3.2.0 Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zachriggle zachriggle

@TethysSvensson TethysSvensson

Labels
backport-complete bug
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zachriggle @TethysSvensson