Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NameError when using hexdump(cyclic=True) #836

Closed
peter50216 opened this issue Jan 9, 2017 · 0 comments
Closed

NameError when using hexdump(cyclic=True) #836

peter50216 opened this issue Jan 9, 2017 · 0 comments
Assignees
@zachriggle @TethysSvensson
Labels
bug
Milestone
3.3.0

Comments

@peter50216
Copy link
Contributor 

from pwn import *
print hexdump('', cyclic=True)

would throw NameError: global name 's' is not defined.

Seems that error comes from some incomplete refactor of hexdump to hexdump_iter.
@zachriggle zachriggle mentioned this issue Jan 9, 2017
Merged
@zachriggle zachriggle self-assigned this Jan 9, 2017
@zachriggle zachriggle added the bug label Jan 9, 2017
@zachriggle zachriggle added this to the 3.3.0 milestone Jan 9, 2017
zachriggle added a commit to zachriggle/pwntools that referenced this issue Jan 10, 2017
@zachriggle
Resolve feature regression in hexdump(..., cyclic=True)
3b9aeb9 
This code wasnt updated when the code was changed to operate on file descriptors.

Additionally, there was a functional regression, that the first line would be skipped.

Fixes: Gallopsled#836
Caused by: Gallopsled#695 (d65991d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zachriggle zachriggle

@TethysSvensson TethysSvensson

Labels
bug
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
3 participants
@zachriggle @peter50216 @TethysSvensson