Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage for Mako Templates #671

Closed
zachriggle opened this issue Aug 18, 2016 · 1 comment
Closed

Coverage for Mako Templates #671

zachriggle opened this issue Aug 18, 2016 · 1 comment
Labels
testing

Comments

@zachriggle
Copy link
Member

Currently, our Shellcraft templates are excluded from coverage, because there's no way for coverage.py to know about the generated Python.

Apparently there is a coverage.py plugin for Mako:
https://bitbucket.org/ned/coverage-mako-plugin

We should investigate using it, so that we can get coverage for shellcraft templates.
@TethysSvensson TethysSvensson added this to the 3.1.0 milestone Aug 20, 2016
@zachriggle zachriggle mentioned this issue Aug 28, 2016
Merged
@zachriggle zachriggle modified the milestones: 3.1.0, Someday Sep 1, 2016
@zachriggle
Copy link
Member Author

It looks like this doesn't actually work:

"Mako template coverage plugin: for measuring coverage in Mako templates. Doesn’t work yet, probably needs some changes in Mako itself."

@zachriggle zachriggle removed this from the Someday milestone Mar 4, 2017
Kyle-Kyle pushed a commit to Kyle-Kyle/pwntools that referenced this issue Apr 25, 2021
@anthraxx @disconnect3d
checksec: try detect different variants and use appropriate args (Gal…
848247e 
…lopsled#671)

Modern maintained checksec >2.0 requires to use "--file=arg" which
we try to detect. The command call is cached anyway so lets try
to find out what version is running.
In case we can't find a verbose variant, we just fall back to the
common old fessioned "--file arg" variant as if nothing has happened.

Fixes Gallopsled#662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zachriggle @TethysSvensson