Node selection pre-highlighting #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These match the equivalent methods on the Widget class.
It was already doing this, but using a private m_hovered member variable rather than the public status.
…get. This reduces the amount of signal handling needed to keep the highlight status up to date, and means other NodeGadget implementations would have one less thing to worry about.
It just uses the highlighting state now that that is kept in sync with the selection by the GraphGadget.
As the user drags out the selection rectangle in the node graph, nodes are highlighted to indicate whether or not they will be selected. This makes it clearer what is about to happen, and avoids ambiguity about whether it is wholly enclosed or merely intersected nodes that will be selected. Fixes GafferHQ#94.
andrewkaufman
added a commit
that referenced
this pull request
Jan 27, 2014
Node selection pre-highlighting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new highlighted state for Gadgets, mirroring the equivalent state already available of Widgets. It then refactors the selection representation in the NodeGraph to use the highlighted state for selected nodes, reducing complexity in the NodeGadgets and dramatically reducing the amount of signal handing required for selection highlight management. Finally it adds selection pre-highlighting for #94.