Scene cache previews #724
Merged
Scene cache previews #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice for previewing animation if the view/browser apps to set the frame range of their timeline based on the sample times in the file. I guess you don't really know a frame range from that though... |
When running "gaffer test ModuleName", the other modules are no longer loaded. This can be useful when running a subset of the tests in an environment where GafferUI won't import due to the lack of an X connection (over ssh for instance).
This returns the current view, which allows its settings to be modified - they are exposed simply as plugs on the View class itself.
This would manifest itself as "invalid framebuffer" errors leaking into the IECoreGL and PyOpenGL code and being reported there, causing various forms of havoc. Fixes GafferHQ#404.
I had hoped that this fix would make the previous commit unnecessary, but testing shows that they address different problems and both are needed. Additionally, although this fixes the initial "invalid drawable" messages on startup, they still appear later on when switching between fullscreen and not-fullscreen. This goes some way to addressing GafferHQ#396, but I suspect it'll be very hard to fix it completely without patching Qt in some way.
This makes it capable of showing more information than just the basic viewer it used before - IndexedIO and header previews for instance.
These are refactored out from the private Viewer toolbar class. Currently they are still only used to present plugs for the Views, but this is a step towards having toolbars for any of the standard nodes.
This is using the same method as is used in StandardNodeUI and CompoundPlugValueWidget. The method itself has flaws (although they're much more likely to be an issue for CompoundPlugValueWidget than for the toolbars), so I've added some more notes as to how we might be able to address them. Also added workaround for labels having an unwanted width, and a todo for getting it fixed.
The later tabs are more specialised and therefore a better guess as to the most interesting for a given path.
|
Thanks for the comments - I've removed the "fixes #396", rolled those two commits together, added the frame range setting you suggested, and rebased it all on top of the current master. |
|
Hmm. I seem to be getting exceptions now. gaffer browser /tmp |
This allows scene caches to be previewed in the browser and view apps. A node toolbar provides options for adding a camera to the scene and having it track a particular object. Fixes GafferHQ#416 and fixes GafferHQ#636 by way of demonstrating how it can be done.
|
Gah. Thanks for spotting that - should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to preview scene caches in both the browser and view apps. The preview allows a camera to be added to the cache, tracking an element within it, to aid in previewing animation.
I've decided against adding a WitnessCamera node accessible to users for now. I'm not totally against the idea, but I think one thing it should provide would be the specification of where the parent for the camera is - and that's not really possible until we allow PathFilters to have inputs. PathFilter inputs are next up on the todo list though so once they're done I'll be happy to listen to arguments for making a variant of the _Camera node into something public.
I'm not particularly enamoured with the new node toolbars - one of my aims is to keep things free of on-screen clutter as much as possible, and they do feel quite cluttered. I'd like to have options for hiding and showing them dynamically in the future, and think about having smaller items in them with popup UIs for editing the details, rather than the current list-of-crap approach. I do think it's worthwhile introducing them even in this form though so we can start to use them and get them refined as we go. The only thing using them at this point is the scene cache preview.
aaf4c2d is worth discussing - when I committed it I believed I had totally irradicated the "invalid drawable" errors, but later discovered that still show up when toggling between fullscreen and non-fullscreen view. Currently I'm out of ideas for fixing that, having spent a good deal of time on it - it may be that we really just need Qt/OS X to get the root cause sorted. Given that, I'm not sure whether it's worth having this partial fix in or not - I'm totally open to removing it if people don't want the extra clutter in the code.