Added Left/Right shortcuts for Timeline frame increment/decrement. #657
Conversation
Also made sure that left/right nudging continues to work for sliders with the focus. Fixes GafferHQ#52.
|
Sounds fine to me. ta. |
|
Any chance someone could review/merge at least this one today? It's only small, but I've got some ideas for Timeline/SceneHierarchy interaction for playback optimisation, and I'd like to work on top of this rather than deal with conflicts later. |
|
OK - I see what's going on here. When you click in the time slider, it has the focus, and all sliders in Gaffer have a left/right hotkey setup for nudging by pixel values (without wraparound) - that's masking the hotkeys I've implemented in this pull request. If you click somewhere else, so the time slider doesn't have focus, and then press left/right you should see what i've implemented... I'm guessing we'd just want to totally disable the default slider behaviour for the timeline slider? |
|
That sounds good to me. |
This allows the cursor key position nudging behaviour to be controlled.
The slider increment behaviour was giving us unwanted nudging by pixel amounts without wraparound, whereas the nice global shortcuts give us increments by the frame with wraparound at the start and end of the timeline.
We need to prevent Qt from passing the cursor keys to our new global shortcut created by the Timeline.
|
OK - I've updated with a fix for the issue you found, and another I found where the new shortcuts were masking the cursor key operations in the PathListingWidget (SceneHierarchy). Should be good to go now... |
Added Left/Right shortcuts for Timeline frame increment/decrement.
This fixes #52, and I think means we can close pull request #559. I've implemented this as a window level shortcut present whenever a Timeline is in the layout, rather than as the menu items Ben had in #559. I believe he only made the menu because it was the only way he had of making a shortcut, rather than because he wanted one. Also, in our cache viewing use case, the main menu doesn't exist so that approach wouldn't work there anyway.