Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDShader : Shader type namespacing and assignment improvements #6083

Draft
wants to merge 1 commit into
base: 1.4_maintenance
Choose a base branch
from

Conversation

boberfly
Copy link
Collaborator

Generally describe what this PR will do, and why it is needed

  • USDShader :
    • A namespace prefix is now set for the shader type from the USD source type, except for USD and glslfx built-ins which correspond to USDLux lights and USDPreviewSurface built-ins
    • Added a way to register namespace overrides from USD shader source types if the resulting USD source type is undesirable
    • The correct shader assignment for displacement and volume shaders are now set for shaders which have a context of displacement or volume

I put this as draft, I am not sure if we want a register or if there's a better way to figure out shader namespacing for shader assignments.

Related issues

  • NA

Dependencies

  • MaterialX but it should be available (need to check the CI)

Breaking changes

  • Added registerShaderNameSpace to USDShader - let me know if this should target main/1.5 instead of 1.4

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

@boberfly boberfly force-pushed the improvements/USDShaderNamespaceAndAssignment branch from bddc80f to a25dd04 Compare October 10, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant