GUI Config : Add LocalDispatcher shutdown checks #5586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murraystevenson
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Thanks John! This looks good to me. The confirmation dialogue per script doesn't feel too inconvenient, it keeps the experience consistent whether you have one or many unsaved scripts open, and it fits the usual pattern followed by other multi-document applications such as Krita, Inkscape, etc.
Adding the "Save" button may introduce some room for debate about whether it or the "Discard" button should be focussed by default, but I'm okay with leaving it as is.
_ChoiceDialogue does feel like it would be a decent addition to GafferUI, maybe something to do the next time we find a use for it...
Since all running jobs will be killed during shutdown prompt the user when closing the last ScriptWindow, offering the option of cancelling shutdown,.
This means we're using the ScriptWindow's own discard/cancel prompts rather than duplicating them here. Which also means that the LocalDispatcher kill-incomplete-jobs? prompt is shown on quit.
johnhaddon
force-pushed
the
localDispatcherShutdownChecks
branch
from
cc2656e
to
9a13360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #5557, adding a prompt at shutdown if there are any LocalDispatcher jobs still running. It required rejigging the Quit action so that it prompts once per window with unsaved changes rather than once for all such windows. But hopefully the potential inconvenience of that is more than offset by the addition of a "Save" button into those prompts, so you can save during quit rather than cancelling, saving and quitting again.
I wasn't sure where a bunch of this code belonged so I've taken the most non-commital approach, leaving old stuff where it was and not adding new stuff (other than
preCloseSignal()to the public API.