GraphComponent : Allow : in names
#5382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmehl
approved these changes
Jul 11, 2023
The immediate motivation for this is to allow the creation of plugs representing UsdLuxLight input names. As the pre-existing comment above `validName()` says, there may be a good case for lifting almost all restrictions, but for now I'm just making the conservatively minimal change needed for the current task.
We were comparing the query plug names against the option name we wanted to query. But the plug names are just `query0`, `query1` etc, so the comparison is meaningless. In fact, the `plugName` argument to `__addQuery` had no affect on the outcome of the function, so I've simply removed it, and the code that was trying to sanitise names by replacing `:` with `_`. I ran into this while looking for places that were avoiding `:` in plug names, since we allow that now anyway.
The user can change the value of the `name` plug after creating the tweak, so it's better to just use a generic name rather than something than can get out of sync.
The user can change the value of the `name` plug later, after which things would be out of sync.
The `name` being passed to `__addTweak()` is always empty, so we never hit the original naming code, and ended up with the first plug being called `tweak` and the second being called `tweak1`. Starting with `tweak0` matches us up with the other tweaks nodes.
johnhaddon
force-pushed
the
colonsInNames
branch
from
3af6aa0
to
947f678
Compare
|
Thanks Eric, I've rebased to fix the merge conflict and am merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some upcoming UsdLux work we need to be able to create plugs representing UsdLuxLight parameters, some of which have
:in their names (e.g.shaping:focus). Rather than introduce some mangling scheme to squeeze that past Gaffer's existing naming restrictions, it's simpler to lift our restrictions. The history of this is that before Gaffer was even in its infancy, I was usingnode.plugNamesyntax in Python to access plugs, but soon grew tired of avoiding Python keywords in plug names, and adopted thenode["plugName"]syntax we use now. The naming restrictions were needed for the original syntax, but there's no need for them any more.After loosening the naming, I went looking for places we had previously mangled names, intending to remove the mangling. But it turned out that in those cases it was better to give the plugs more generic names anyway. So that's what I've done in the subsequent commits.