Commits on Jun 6, 2022

1. ColorSwatchPlugValueWidget : Fix dialogue for Tool plugs …

   I'm not sure if this is the right long-term fix or not, but it works for our immediate needs (a custom Tool subclass with a ColorPlug). It wouldn't work for, say, a plug in the LightEditor settings, where there's no way of finding the script from the parent-less settings node. As discussed in GafferHQ#50, it might be ideal if the entire UI hierarchy was specified via Nodes/Plugs, and then this approach could work for the LightEditor and everything else too.
   
   An alternative approach would be to pass a `forWidget` argument to `acquire()` and then find a suitable parent window for the dialogue from that. But that is a bit harder to use, and also means we could end up with multiple colour dialogues (under different windows) for the same plug, which is what we're trying to avoid.

   

   johnhaddon committed Jun 6, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 50925d1
   • Browse repository at this point

   Copy the full SHA

   50925d1 View commit details

   Browse the repository at this point in the history