Experimenting with double pull requests... #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, and that it can only return leaf plugs in the output. Dirtiness is still signalled on parent CompoundPlugs as a convenience to observers, but the actual specification of dependencies is enforced to only take place at the leaf level because that is the only level computations may take place at. This fixes bugs where the various UI elements wouldn't always update correctly because dirtiness wasn't being propagated fully. These bugs had become much more severe following the addition of the preprocessor node inside the SceneView because the preprocessor itself wasn't properly propagating dirtiness.
…at the path is changed multiple times in between draw events. This was particularly important for the SceneHierarchy editor which was performing repeated updates due to multiple plugDirtiedSignals() being emitted. Path changed signals are now batched up and dealt with once only on the next idle event after the change.
lucienfostier
referenced
this pull request
in lucienfostier/gaffer
Apr 4, 2017
lucienfostier
referenced
this pull request
in lucienfostier/gaffer
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.