-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes Update : Add most recent changes to master #3213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did I catch all of them?
Not sure - looks like all the CompoundEditor stuff is missing? And ExtensionAlgo?
What to do about 0.53.6.1?
I don't think we need to worry about tit.
Changes
Outdated
@@ -69,6 +69,10 @@ Improvements | |||
- MeshTangents : Added support for additional computation modes (#3030). | |||
- GafferImageUI: Added DWA compression presets (#3153). | |||
- Numeric Bookmarks : Added serialisation to preserve numeric bookmarks across sessions (#3157). | |||
- SetExpressions : Support wildcard characters in set names (#3172). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid the weird imperative mood that we use for commit messages - our main audience is the end user here, not developers.
Changes
Outdated
@@ -69,6 +69,10 @@ Improvements | |||
- MeshTangents : Added support for additional computation modes (#3030). | |||
- GafferImageUI: Added DWA compression presets (#3153). | |||
- Numeric Bookmarks : Added serialisation to preserve numeric bookmarks across sessions (#3157). | |||
- SetExpressions : Support wildcard characters in set names (#3172). | |||
- LightVisualisers : Added "visualiserScale" attribute (#3180). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace with the user-facing part of this : the new visualiserScale
plug on Light nodes.
Changes
Outdated
@@ -69,6 +69,10 @@ Improvements | |||
- MeshTangents : Added support for additional computation modes (#3030). | |||
- GafferImageUI: Added DWA compression presets (#3153). | |||
- Numeric Bookmarks : Added serialisation to preserve numeric bookmarks across sessions (#3157). | |||
- SetExpressions : Support wildcard characters in set names (#3172). | |||
- LightVisualisers : Added "visualiserScale" attribute (#3180). | |||
- StandardLightVisualiser : Avoid computations entirely by setting visualiserScale to 0 (#3178). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid the imperative.
@@ -97,6 +101,7 @@ Fixes | |||
- Fixed bug when deselecting a curve - the plug listing selection was not being updated | |||
to reflect the change. | |||
- PythonCommand : Prevented inadvertent modification of outer context (#3101). | |||
- Fixed widget signal/slot lifetime issues (#3179). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should mention the new recommended way of managing widget connections?
Changes
Outdated
- SetExpressions : Support wildcard characters in set names (#3172). | ||
- LightVisualisers : Added "visualiserScale" attribute (#3180). | ||
- StandardLightVisualiser : Avoid computations entirely by setting visualiserScale to 0 (#3178). | ||
- CustomAttributes : Added extraAttributes plug (#3191). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this covered in the 0.53.6.2 section below?
Changes
Outdated
|
||
- MultiLineTextWidget : Fixed unicode handling in `selectedText()` (#3183) | ||
- SplineWidget : Fixed display transform management bug (#3187) | ||
- ArnoldLight : Rejig `loadShader()` to fix "nodule:type" metadata (#3188) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid the imperative, and make the message meaningful to the end user (nodules no longer disappear when copy/pasting Arnold quad_light and skydome_light nodes).
Hey John - thanks for your feedback. I've tried to address it in f85228b. Could you have a look and let me know if there's anything that still needs changing? Thanks! :) |
Thanks Matti - looks good to me. I've just restarted the Mac test which failed for an unrelated reason. Seeing quite a few of these (crashes in GraphEditorTest.testAutomaticLayout), but haven't been able to reproduce locally. |
Did I catch all of them? What to do about 0.53.6.1? That was just that minor change that introduced that warning regarding out light linking issue.
Thanks! :)