Layouts/LayoutMenu : Improve management of custom layouts #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be in favor of the Default Layout Submenu. That's very handy in some other apps, where I know my default is the shipped "Technical" layout, and it updates whenever we get new versions of the app. |
OK, cool, I'll sort that out. Should we rename the layout currently called "Default" to "Standard" so we don't have the confusing situation of it not actually being the default one? |
|
Sure, Standard works |
- LayoutMenu : - New "Default/..." submenu allows the default layout to be chosen - New "Save As/*" options allow previously saved layouts to be replaced - Layouts : - Added `persistent` argument to `add()` method, mirroring the `Bookmarks.add()` API. This automatically takes care of saving persistent layouts into the startup location. - Added `setDefault()/getDefault()` and `createDefault()` methods to allow the management of a default layout. Breaking Changes : - Layouts : - Removed `save()` method. Use the `persistent` argument to `add()` and `setDefault()` instead. - Added applicationRoot argument to constructor. You should use `acquire()` instead anyway. - LayoutMenu : - Removed `delete()` method. - GUI config : Renamed standard layout from "Default" to "Standard". Fixes GafferHQ#51
|
OK, pushed those changes. Also removed the menu items to save over the standard layouts (but kept the items to save over existing custom layouts). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stab at implementing the layout improvements requested in #51 - the ability to replace the existing layouts, including the Default one. Have a play with it and see what you think.
I have a couple of queries :
Default layout mechanism
Currently you replace the default layout by saving a layout and naming it "Default" (handled for you by the "Save As/Default" menu item. Would it instead be better to just choose which is the default layout from the current list of layouts via a "Default Layout" submenu with a series of checkboxes? Consider this sequence of operations :
Deleting layouts
You can currently temporarily delete a standard layout as follows :
It will only become available again on a restart, when the config files are reloaded. Should I instead make it so that deleting the custom version causes us to revert back to the standard one?
I feel like maybe both those things are worth sorting out?