Shader reloading #135
Merged
Shader reloading #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…managed by the base Shader class.
…t not the declaration.
RenderManShader::loadShader() may now be called passing keepExistingValues=true, to update the node status when a shader has changed on disk. This is done automatically after loading a script, so that the nodes should always be in sync with what's on disk. Also added support for min and max shader annotations which are supported for float, vector, point, normal and color shader parameters. Still need to add UI elements to expose the reloading to users.
Parameterising VectorTypedParameterHandler on the parameter type rather than on the element type. This allows us to pick up the correct DataType for V3fVectorParameter by using the typedef provided by TypedParameter.
…aderReloading Conflicts: src/Gaffer/VectorTypedParameterHandler.cpp
lucienfostier
referenced
this pull request
in lucienfostier/gaffer
Apr 4, 2017
lucienfostier
referenced
this pull request
in lucienfostier/gaffer
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.