Improved scene path dialogues #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase |
This tongue twister uses any of the GafferScene::Filter nodes to implement a Gaffer::PathFilter to filter the children of a GafferScene::ScenePath.
This is analogous to the method of the same name on FileSystemPath, and makes it easy to construct a filter based on sets.
This appears to have been broken since the last minute attribute->property rename in GafferHQ#1190, and was preventing the search box in file open dialogues from working.
This allows customisations to the dialogue contents to be made.
This may be overridden by derived classes to provide more control over the appearance of the dialogue.
This is a subclass of PathPlugValueWidget specialised for choosing paths within a scene. It supports metadata for controlling filtering based on set membership.
johnhaddon
force-pushed
the
cameraChooser
branch
from
3b80648
to
15af2d9
Compare
|
Rebased. |
andrewkaufman
added a commit
that referenced
this pull request
Apr 28, 2015
Improved scene path dialogues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements Mathias' request to filter the path chooser to only show cameras when picking the render camera. It turned out to be a bit more involved than I thought it might, but along the way I've fixed a couple of important bugs that cropped up in the paths framework, and improved the path choosers for all scene paths. The "filtering paths based on a Filter node" functionality also gives us the basis for #48.