Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dirty propagation test for ContextVariables #1230

Closed
wants to merge 1 commit into from
Closed

Added dirty propagation test for ContextVariables #1230

wants to merge 1 commit into from

Commits on Mar 11, 2015

  1. Added dirty propagation test for ContextVariables 

    Two things seem to be failing here. To start with, it looks like tweaking a value on a ContextVariables node doesn't signal dirtiness properly, because ContextVariables<BaseType>::affects() isn't implemented correctly.
The other problem seems wider ranging: adding a member to/removing it from the "variables" plug on a ContextVariables node (and similar nodes) should trigger a propagateDirtiness and dirty its output, seeing as it affects its value. This seems problematic though - I tried calling propagateDirtiness( this ) in CompoundPlug::childAddedOrRemoved(), but compound plugs don't trigger calls to affects(), so that was the end of that. This is probably affecting other nodes with compound plugs like GafferScene::CustomAttributes too.
    @davidsminor
    davidsminor committed Mar 11, 2015
    Configuration menu
    Copy the full SHA
    feee896 View commit details
    Browse the repository at this point in the history