Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise appearance of enable/disable for node parameters #65

Closed
bentoogood opened this issue Mar 28, 2013 · 5 comments
Closed

Revise appearance of enable/disable for node parameters #65

bentoogood opened this issue Mar 28, 2013 · 5 comments
Assignees
@johnhaddon
Labels
bug Issues representing bugs
Milestone
Optional misc imp...

Comments

@bentoogood
Copy link
Contributor

The enable/disable mechanism could be a little confusing to users, especially for bool params where the enable/disable toggle has the same appearance as the value toggle.

Also - as some params have enable/disable and some don't, how best can we communicate its use?
@ghost ghost assigned johnhaddon Mar 28, 2013
@ghost ghost assigned bentoogood Sep 23, 2013
@bentoogood
Copy link
Contributor Author

couple of options for consideration:

onoff1
onoff2

@bentoogood
Copy link
Contributor Author

Top option is the pick.
Some notes to address when we make the svg:

  • bend to the right-hand-world-order and make < off and > on
  • loose the darkening when off and lighten the bg a little for on

bentoogood pushed a commit that referenced this issue Sep 24, 2013
adds new toggle icons
cb1f10a 
* for use with compound plugs that have an enable/disable toggle
* contributes to #65
* new icons labeled "toggleOn", "toggleOnHover" "toggleOff" "toggleOffHover"
* no disabled modes - can be added if required
@ghost ghost assigned johnhaddon Oct 4, 2013
@bentoogood
Copy link
Contributor Author

icons are in, over to John to add new widget type.

@johnhaddon
Copy link
Member

Thanks Ben - my plan is to rename GafferUI.CheckBox to GafferUI.BoolWidget and then add methods to control the appearance (switch/checkbox). I'll keep CheckBox around as an alias to BoolWidget to provide backwards compatibility for a bit though. Sound OK?

@bentoogood
Copy link
Contributor Author

sounds fine to me.

@leonard7e leonard7e mentioned this issue Mar 19, 2015
Closed
lucienfostier referenced this issue in lucienfostier/gaffer Apr 4, 2017
@lucienfostier
ImageWriter: Added Expression node to control colorspace plug.
7e8ad35
lucienfostier referenced this issue in lucienfostier/gaffer Apr 7, 2017
@lucienfostier
ImageWriter: Added metadata node to inject colorspace name
18b33b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnhaddon johnhaddon

Labels
bug Issues representing bugs
Projects
None yet
Milestone
Optional misc improvements
Development

No branches or pull requests
2 participants
@johnhaddon @bentoogood