Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color space management to the 2d viewer #573

Closed
thiasbxl opened this issue Oct 3, 2013 · 3 comments
Closed

Add color space management to the 2d viewer #573

thiasbxl opened this issue Oct 3, 2013 · 3 comments
Labels
image Issues with GafferImage
Milestone
3.06 - Shader Set...

Comments

@thiasbxl
Copy link

thiasbxl commented Oct 3, 2013

We need the ability to select the color space for the 2d viewer : sRGB / Rec709 / DCIP3 / ...

this is part of #73
@johnhaddon
Copy link
Member

When doing this, we should consider if/how this is linked into the global display transform used by all the colour pickers, swatches, ramps etc.

@johnhaddon
Copy link
Member

Is this one really that low in priority that it should be in this distant milestone? Unless something unexpected trips me up, it shouldn't be too hard to do this one at the same time as #571 in the earlier milestone.

@bentoogood
Copy link
Contributor

If you can squeeze it in that's fine.

johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Nov 8, 2013
@johnhaddon
Added colourspace management to the image viewer.
7b0baf6 
The ImageView class allows arbitrary ImageProcessors to be registered as colour transforms, and chosen using a new "displayTransform" plug. The ocio.py config file registers a processor for each display transform in the OpenColorIO config, and a Default transform which tracks the global display transform specified via the preferences.

Fixes GafferHQ#573.
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Nov 11, 2013
@johnhaddon
Added colourspace management to the image viewer.
f8af2de 
The ImageView class allows arbitrary ImageProcessors to be registered as colour transforms, and chosen using a new "displayTransform" plug. The ocio.py config file registers a processor for each display transform in the OpenColorIO config, and a Default transform which tracks the global display transform specified via the preferences.

Fixes GafferHQ#573.
@johnhaddon johnhaddon mentioned this issue Nov 13, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
image Issues with GafferImage
Projects
None yet
Milestone
3.06 - Shader Setup Aids part 2
Development

No branches or pull requests
3 participants
@johnhaddon @bentoogood @thiasbxl