Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to visualize clipping colors in the 2d viewer #572

Closed
thiasbxl opened this issue Oct 3, 2013 · 4 comments
Closed

Add a way to visualize clipping colors in the 2d viewer #572

thiasbxl opened this issue Oct 3, 2013 · 4 comments
Labels
image Issues with GafferImage

Comments

@thiasbxl
Copy link

thiasbxl commented Oct 3, 2013

Can we please add a display clipping toggle in the 2d viewer. Like in Nuke it would display pure black pixels where any channel value gets over 1.0 and pure white pixels wherever any channel value gets negative.

this is part of #73

@johnhaddon
Copy link
Member

Would I be right in assuming that this clipping should be applied after exposure/gamma and before the display transform?

@thiasbxl
Copy link
Author

No the clipping must be applied right after the linear data is output to the viewer, same as color sampling/picking.

As a side note, It would be nice if we were able to choose to display clipped areas as colors. Red for overbright values and blue for negatives. This would make a lot easier to see when the input image/texture is greyscale.

@johnhaddon
Copy link
Member

OK. So when you're dialing up exposure you're not ever thinking "let's see if it would it clip if it was twice as bright?" or anything of that sort?

My plan for implementing the clipping was to use Richard's clamp node, which won't give you red/blue, it'll give you per-channel 0/1.

@danieldresser
Copy link
Collaborator

Just had a chat with Mathias about this. He's OK with the per channel invert at the clipping point for the moment, and is quite resolute that having the exposure dial influence clipping would be weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
image Issues with GafferImage
Projects
None yet
Development

No branches or pull requests

3 participants