Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: bookmarks in all file browser windows #5592

Closed
BrianHanke opened this issue Dec 18, 2023 · 5 comments
Closed

Feature request: bookmarks in all file browser windows #5592

BrianHanke opened this issue Dec 18, 2023 · 5 comments

Comments

@BrianHanke
Copy link
Contributor

It would be great if the bookmarks icon was available in this type of window. (This is the aiImage file browser.)

gfr

johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Dec 18, 2023
@johnhaddon
Copy link
Member

I've added the bookmarks for the image shader in #5593, as well as improving the browsers for photometric_light and color_manager_ocio. I wasn't sure what else you might be referring to by "all" browsers, so I also improved USDLight and OpenColorIOContext, which were the obvious ones with the same bookmarks categories as the Arnold ones I'd just done. Happy to add more if I've missed some (or alternatively, if you check out the PR it should be pretty obvious how to add them yourself if you'd be up for contributing).

@BrianHanke
Copy link
Contributor Author

Wow, thanks John! Works great. I noticed one other spot last night, but can't remember now. It's clear how it works so I'll submit a change next time I run across it.

On a related note, is it possible to have each file browser share the same bookmarks? Right now aiImage and File > Open for example have their own separate bookmarks list.

@johnhaddon
Copy link
Member

On a related note, is it possible to have each file browser share the same bookmarks? Right now aiImage and File > Open for example have their own separate bookmarks list.

It is possible to have file browsers share bookmarks, yes - we actually went out of our way to separate them in this case! Bookmarks are separated by category, and the FileMenu is using a category of script while the image shader is using texture. The assumption is that you'd keep different things in different places and therefore want different bookmarks for them.

You can't currently change the category used by the FileMenu, but you could add your own .mtd file (like the one in the PR) to change the Arnold category.

Alternatively, it's possible to script the creation of bookmarks, including applying them to all categories. If there are a common set of locations you want to always be available, you might find that worthwhile. There's a short tutorial on that here : https://www.gafferhq.org/documentation/1.3.8.0/WorkingWithThePythonScriptingAPI/TutorialStartupConfig2/index.html.

@BrianHanke
Copy link
Contributor Author

Makes sense to keep them separate, I had a feeling that was what you were going for! Thanks for the tips, I'll look into customizing it.

@BrianHanke
Copy link
Contributor Author

All set! That tutorial let me hardcode a universal set of project-related bookmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants