Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define default colour scheme for nodes and add preferences mechanism #154

Open
1 of 3 tasks
bentoogood opened this issue Apr 10, 2013 · 4 comments
Open
1 of 3 tasks
Assignees

Comments

@bentoogood
Copy link
Contributor

  • We need to design a suitable default colour scheme for node types.
  • Then given that users may personal preferences over colour schemes, we should provide a preferences mechanism for user to set their owns schemes (still driven by type)
  • Additionally, users may wish to manually colour specific nodes in their graphs. This will require a new per node colour mechanism.
@bentoogood
Copy link
Contributor Author

being handled graffer side for now, so moving out of milestone.

@bentoogood
Copy link
Contributor Author

A detail to consider when implementing the node colouring gaffer side.

In graffer right now, if I duplicate a node (ctrl-c,ctrl-v) the duplicate does not inherit any nodeColor that the source has.

@johnhaddon
Copy link
Member

The reason this is happening in Graffer is that the Graffer nodeGadgetCreator decides on a colour based on the shader being held on the node. But when the node is first added to the script during cut and paste, the shader has not yet been loaded.

@johnhaddon
Copy link
Member

This relates to #89, so they may as well be done together.

johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Dec 17, 2014
Kindof fixes GafferHQ#89 and kindof fixes GafferHQ#1098 and either fixes or lays the foundations for GafferHQ#154, but I'm sure other people will have different ideas on what colours are best.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants