-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit version to addons.mozilla.org #2
Comments
You should remove unnecessary files from the addon pack. Then use web-ext lint to verification. |
Thanks, I'll definitely try this when I get some more time. Since I already have eslint running, I suspect it's the Maybe generating the whole I tried to bundle everything with webpack, but I had troubles with A workaround I see could be to use a cdn instead so I could avoid Concerning the web-ext lint, I suppose it shouldn't be too hard to include this in de dev pipeline in webpack. I even plan to do the extension release creation from travis later. Thanks for the hints :) |
I believe it could be very cool to submit this plugin ! There is actually no cool plugin who replaced Norwell ! And there was a lot of user who used it ! :-) ! |
I'm looking into this right away, I'll try a bit more with |
So cool ! Thanks ! |
As I was suspecting, all of the lint errors happen in npm i -g web-ext
npm i && bower i
npm run build
web-ext lint -s=addon web-ext lint output
Currently trying to get rid of |
I think I'll be ok with #5 in place, I ran
Only a small issue with bootstrap fonts and webpack left 👍 |
WIP: replace bower with webpack for #2
🎉 |
So I tried to submit this, but I'm getting some linter errors even tho I started with linting.
They're linking to https://github.com/mozilla/addons-linter/ so I may have to set something like that in the project.
Here's what I tried for the release (started from scratch to make sure release was clean)
Then I uploaded
webextensions-history-browser.zip
.The text was updated successfully, but these errors were encountered: