Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git error in gha build #7

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Fix git error in gha build #7

merged 4 commits into from
Jul 12, 2022

Conversation

eigenraven
Copy link
Member

Turns out git describe as done by forgegradle doesn't work in shallow clones

@eigenraven eigenraven requested a review from a team July 12, 2022 06:59
@eigenraven
Copy link
Member Author

It finally worked :D Turns out the "adopt" java distribution leads to different decompilation results from the default openjdk distributed by ubuntu (and arch linux on my local pc), breaking patches.

@Dream-Master Dream-Master merged commit ab8a329 into 1.7.10 Jul 12, 2022
@Dream-Master Dream-Master deleted the fix-gha branch July 12, 2022 08:17
@Dream-Master
Copy link
Member

Guess we remove master branch and rename 1.7.10 to master @eigenraven

@eigenraven
Copy link
Member Author

Guess we remove master branch and rename 1.7.10 to master @eigenraven

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants