Fix crashes related to high level enchantments. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrParadox7
pushed a commit
to DrParadox7/ThaumicTinkerer
that referenced
this pull request
Jun 12, 2024
* Fix crashes with high level enchantments. * bs+d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar issues to GTNewHorizons/Thaumic_Exploration#35:
Final Strike enchant:
Before, level 19 or higher would cause
IllegalArgumentExceptionby passing a zero or negative number toRandom.nextInt().Now, level 19 and higher guarantees success.
Quickdraw enchant:
Before, level 6 would cause a division by zero, level 7 or more would get progressively worse than level 5. (This is due to use of the modulo function.)
Now, draw speed continues to increase beyond level 6 in a similar manner as before. Note that the logic was slightly reworked, but for levels 1-5 the draw speed increase is equivalent to before. (That is, every
6 - levelticks, draw time is reduced by one tick.)