Move Steve's Addons ASM to explicit compat #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ah-OOG-ah on mod need the other code to load that is the problem. I am not sure how to setup this? |
|
Merged into dev - seems to work now. |
|
Should build and not break anything now. |
|
Instead of calling addon's methods from base mod (and so create circular dependency), it's better to create clear API that can be implemented/overridden in addon. |
Also cache isModLoaded
|
It's not really an API, it's specifically for Steve's Addons. However, it doesn't require Steve's Addons to compile, so no circular dep. |
OneEyeMaker
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Steve's Addons ASM into code directly, with isModLoaded checks. Requires this PR in Steve's Addons.
Additionally, minor license cleanup: the tweet screenshot is now directly in the repository and the license is in text as well.
Also, moves to Tags.java instead of token replacement in a file.
This doesn't load in nightly 310, and I have no idea why. Also, needs testing by people who use SFM.