Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with Angelica when looking at hydrodam pressurized water #24

Merged
merged 3 commits into from
May 13, 2024

Conversation

dvdmandt
Copy link

@dvdmandt dvdmandt commented May 3, 2024

This is a workaround for GTNewHorizons/Angelica#195, where the client crashes when looking at Hydrodam water. It makes the conditions of this statement false, causing it to use the seemingly Angelica compatible alternative path instead.

Note that I couldn't get the build system to replace the GRADLETOKEN_GROUPNAME token, so I replaced it manually for now. Let me know if there's a better way.

@dvdmandt
Copy link
Author

dvdmandt commented May 3, 2024

Also fixed the crash when returning to main menu after entering a world with a hydrodam.

@Dream-Master Dream-Master requested a review from a team May 4, 2024 08:29
@Caedis Caedis requested a review from mitchej123 May 10, 2024 06:42
@Caedis
Copy link
Member

Caedis commented May 10, 2024

Should probably properly fix it rather than relying on limited rendering

@Alastors
Copy link

Idk, I think it's significantly more important that crashes don't happen in the first place

@dvdmandt
Copy link
Author

Should probably properly fix it rather than relying on limited rendering

I don't disagree, but I'm not sure what even makes it "limited" in this case, and it's not a hugely popular mod/mechanic, so it doesn't strike me as the highest priority thing to spend time on.

@Alastors
Copy link

Should probably properly fix it rather than relying on limited rendering

I don't disagree, but I'm not sure what even makes it "limited" in this case, and it's not a hugely popular mod/mechanic, so it doesn't strike me as the highest priority thing to spend time on.

Yeah SirThor left a long time ago

Copy link
Member

@Caedis Caedis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now

@Dream-Master Dream-Master merged commit 94790e4 into master May 13, 2024
1 check passed
@Dream-Master Dream-Master deleted the fix-angelica-crash branch May 13, 2024 05:24
Dream-Master added a commit that referenced this pull request May 20, 2024
Fix crash with Angelica when looking at hydrodam pressurized water

(cherry picked from commit 94790e4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants