-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash with Angelica when looking at hydrodam pressurized water #24
Conversation
Also fixed the crash when returning to main menu after entering a world with a hydrodam. |
Should probably properly fix it rather than relying on limited rendering |
Idk, I think it's significantly more important that crashes don't happen in the first place |
I don't disagree, but I'm not sure what even makes it "limited" in this case, and it's not a hugely popular mod/mechanic, so it doesn't strike me as the highest priority thing to spend time on. |
Yeah SirThor left a long time ago |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for now
Fix crash with Angelica when looking at hydrodam pressurized water (cherry picked from commit 94790e4)
This is a workaround for GTNewHorizons/Angelica#195, where the client crashes when looking at Hydrodam water. It makes the conditions of this statement false, causing it to use the seemingly Angelica compatible alternative path instead.
Note that I couldn't get the build system to replace the GRADLETOKEN_GROUPNAME token, so I replaced it manually for now. Let me know if there's a better way.