Extract all contributors into the changelog credits section in the compressed changelog #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlhlm
changed the title
chochem
reviewed
Dec 6, 2024
wlhlm
changed the title
wlhlm
force-pushed
the
you-get-a-credit-and-you-get-a-credit-and-you-get-a-credit
branch
from
ecbafdb to
34141e9
Compare
…butions instead of just "new" contributors
wlhlm
force-pushed
the
you-get-a-credit-and-you-get-a-credit-and-you-get-a-credit
branch
from
34141e9 to
7947b45
Compare
boubou19
approved these changes
Dec 6, 2024
boubou19
deleted the
you-get-a-credit-and-you-get-a-credit-and-you-get-a-credit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior was to only include "new" contributors in the credits sections which where drawn from the changelog itself from the new contributor sections for each changed mod. However that does not account for people who have contributed to other repositories in our organization and it sweeps returning contributors under the rug.
It's a good idea to make special mention of new contributors, but that needs a more comprehensive approach most likely pulling from the GitHub API to do it across all repositories.
For demonstration, I have included an updated 2.7.0-RC-2 to -RC-3 changelog.