LGPL-3.0 #6
Merged
LGPL-3.0 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glowredman
reviewed
Feb 1, 2022
repositories.gradle
Outdated
| @@ -9,9 +13,6 @@ repositories { | |||
| artifact() | |||
| } | |||
| } | |||
| maven { | |||
| url "https://cursemaven.com" | |||
| } | |||
There was a problem hiding this comment.
Don't delete this, witchery is still fetched from there. Actually you could probably convert it to a deobf dep aswell and thus getting rid of the need for CCC
There was a problem hiding this comment.
deobf witchery can't handle the mixin it needs to do apparently:
java.lang.NoSuchMethodError: com.emoniph.witchery.brewing.potions.PotionParalysis.registerPotionAttributeModifier(Lnet/minecraft/entity/ai/attributes/IAttribute;Ljava/lang/String;DI)Lnet/minecraft/potion/Potion;
at com.emoniph.witchery.brewing.potions.PotionParalysis.postContructInitialize(PotionParalysis.java:35) ~[PotionParalysis.class:?]
at com.emoniph.witchery.brewing.potions.WitcheryPotions.register(WitcheryPotions.java:186) ~[WitcheryPotions.class:?]
at com.emoniph.witchery.brewing.potions.WitcheryPotions.<init>(WitcheryPotions.java:62) ~[WitcheryPotions.class:?]```
All my normal tricks fail here, will read the curse version
There was a problem hiding this comment.
Maybe the mixins only contains the obfuscated name which works fine in non-dev but not in dev with an actually deobfuscated version of Witchery?
There was a problem hiding this comment.
Wait, no, there is not even Mixins involved in this case
There was a problem hiding this comment.
got a wacky runtime fix for now so runServer passes, but not sure what witchery wants to run in dev
This reverts commit 33c12a3.
Dream-Master
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update buildscript, clarify and license to LGPL-3.0 to match Crops++ and tag and push to maven