-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport Froglights + Additional Froglights #48
Conversation
Backported 3 froglights and added 6 more Pearlescent, Ochre, Veridium, and the 6 custom ones meant to look like Osmium, Tungstensteel, Iron, Titanium, Aluminium, and Grisium
Backport Froglights
Fix typo in en_US
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the first three textures the same as in modern MC? If so, we can't include them in the mod.
How does EFR get around the reuse of modern resources? Is it because EFR is LGPL while this is only GPL? |
Its ok if you modify some pixels so its not the original texture?.., or how it works the license of textures? |
See https://www.minecraft.net/en-us/usage-guidelines: "Do not redistribute our games or any alterations of our games or game files". IANAL but to me that sounds like "do your own textures". Alterations of official textures may count as fair-use but again, IANAL. |
I never actually considered licensing, will have to be more careful with that in the future I guess. |
@glowredman I changed the bottom-left lamp to have a different texture, do you think this is different enough to fall under fair use? If so, I can polish it up a bit more and change the rest |
- Removed assets for variations 0-8 - Replaced 0-8 with different themed assets - Added variation 9
Change former assets to comply with minecraft's EULA
spotlessApply
@GirixK are you still working on this ? Feature freeze is over |
As far as I'm concerned, I believe it's done, I feel like the currently colors are varied enough to fit plenty of themes and sceneries Only things I'm not sure about is incrementing the version number, as well as potentially a cheaper assembler recipe, but I don't actually know how to properly do the assembler recipe |
the recipes can be easy added in the core mod. But i need to know what about the graphic licens? We need to take care that we not get into copyright issues @GirixK |
The first screenshot in this pr is the one which violates the license, the latest image is the (current) assets I've heavily modified and should no longer violate the license, so I'm fairly certain it's free to use 👍 |
so you mean this @GirixK ? |
This are the original ones @GirixK ? |
if so what do you think ? @glowredman @mitchej123 @boubou19 |
Yes, the 3x3 is mojang assets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Adding the vanilla Pearlescent, Ocher, and Verdant froglights
As well as adding 6 new ones, based on the following materials, in no particular order:
Osmium, Tungstensteel, Iron, Titanium, Aluminium, and Grisium.
These blocks offer several slight variations based on various metals and alloys
They fill the purpose of "natural" feeling full-block light sources
I could add more in the future, but for now I didn't want to overdo it, as most of these didn't exactly have a great deal effort put into them, I mostly just felt there was a gap that could be filled using this block.
I might revisit and re-do some of the less clear textures in the future, but for the time being, I'm personally satisfied.