Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't relocate CTMLib #37

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

makamys
Copy link

@makamys makamys commented Dec 28, 2023

Techguns uses the shaded CTMLib at the team.chisel.ctmlib package name. This was the package name used by upstream, and also in this fork prior to 2.10.17. In 2.10.17 this was changed to com.cricketcraft.chisel.shadow.team.chisel.ctmlib during the RFG migration, most likely by mistake. This PR restores the old package name, fixing this crash:

java.lang.NoClassDefFoundError: team.chisel.ctmlib.ISubmapManager
  at techguns.TGBlocks.init(TGBlocks.java:290) ~[TGBlocks.class:?]

Fixes Techguns compat
@mitchej123 mitchej123 merged commit 3e6930d into GTNewHorizons:master Dec 28, 2023
1 check passed
@makamys makamys deleted the fix-techguns branch December 28, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants