Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 7 new sets of blocks #27

Merged
merged 12 commits into from
Apr 25, 2023
Merged

Conversation

Jimbno
Copy link

@Jimbno Jimbno commented Apr 23, 2023

Added 7 new sets of chisel blocks:

-Hempcrete and hempcrete powder, vanilla concrete look-alike.
-Neonite, antiblock-like w/o the borders and a whole different colour palette
-Glotek, decorative glowie blocks
-Sveltstone, neutral tone, smooth textured stone type blocks
-Cubits, smooth grayscale blocks
-Structural concrete, an attempt to imitate real life concrete

9NDOypm - Imgur

Added 7 new sets of chisel blocks
@Dream-Master Dream-Master requested review from a team April 23, 2023 15:17
@Dream-Master
Copy link
Member

@Jimbno add this and the action bot works
Jimbno#1

@Jimbno
Copy link
Author

Jimbno commented Apr 23, 2023

where do I need to add that

@Dream-Master
Copy link
Member

add it and the pr here will build

@Dream-Master
Copy link
Member

Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the stuff I commented on good work 👍

src/main/java/team/chisel/Features.java Outdated Show resolved Hide resolved
src/main/java/team/chisel/Features.java Outdated Show resolved Hide resolved
src/main/java/team/chisel/Features.java Outdated Show resolved Hide resolved
src/main/java/team/chisel/block/BlockCarvableGlotek.java Outdated Show resolved Hide resolved
src/main/java/team/chisel/block/BlockCarvableNeonite.java Outdated Show resolved Hide resolved
src/main/java/team/chisel/block/BlockHempcreteSand.java Outdated Show resolved Hide resolved
implemented some of glowredmans suggestions
Added the rest of suggestions,
made one class for glotek and neonite, made variable names more descriptive and removed SideOnly
merged glowtek and neonite carvable into one calss
@Jimbno
Copy link
Author

Jimbno commented Apr 24, 2023

So im pretty sure neonite and glotek are causing it to crash when you try to run server, not sure how to fix that,

@glowredman
Copy link
Member

glowredman commented Apr 24, 2023

Copy from #mode-dev:

You removed the @SideOnly annotations on SubmapManagerSpecialMaterial#registerIcons and SubmapManagerSpecialMaterial#createRenderContext where they were actually needed.
Use @SideOnly(Side.CLIENT) when you're overriding a method which has client-only classes in it's signature (In this case RenderBlocks / IIconRegister). Client-only classes are all classes within the net.minecraft.client package

@Connor-Colenso Connor-Colenso merged commit 65d2a18 into GTNewHorizons:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants