Fix Mixin log warning about max shift limit #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer you jhust edit the mixin in question and remove the max shift by, I made the mixin and iirc it shouldn't cause any issue, the decompile code will just be ugly |
|
Would that require changing the |
yes |
|
well actually I'm trying rn and it doesn't work you need to change the mixin handler too xd |
Alexdoru
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this log message about the max shift limit
@Inject(@At("INVOKE")) Shift.BY=2 on mixins.battlegear2.early.json:MixinInventoryPlayer from mod battlegear2::handler$zmb000$battlegear2$readFromNBT$setItems exceeds the maximum allowed value: 0. Increase the value of maxShiftBy to suppress this warning.