Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FoodStats crash with Thermos #27

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Fix FoodStats crash with Thermos #27

merged 4 commits into from
Aug 25, 2023

Conversation

miozune
Copy link
Member

@miozune miozune commented Aug 24, 2023

Tested on private server.

relevant crash log java.lang.NullPointerException at squeek.spiceoflife.foodtracker.FoodHistory.get(FoodHistory.java:54) ~[FoodHistory.class:?] at squeek.spiceoflife.foodtracker.FoodModifier.getFoodModifier(FoodModifier.java:61) ~[FoodModifier.class:?] at squeek.spiceoflife.foodtracker.FoodModifier.getFoodValues(FoodModifier.java:53) ~[FoodModifier.class:?] at cpw.mods.fml.common.eventhandler.ASMEventHandler_1241_FoodModifier_getFoodValues_GetPlayerFoodValues.invoke(.dynamic) ~[?:?] at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) ~[ASMEventHandler.class:1.7.10-1614.UNOFFICIAL] at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) [EventBus.class:1.7.10-1614.UNOFFICIAL] at squeek.applecore.api_impl.AppleCoreAccessorMutatorImpl.getFoodValuesForPlayer(AppleCoreAccessorMutatorImpl.java:85) [AppleCoreAccessorMutatorImpl.class:?] at net.minecraft.util.FoodStats.func_151686_a(FoodStats.java:583) [zr.class:?] at net.minecraft.item.ItemFood.func_77654_b(SourceFile:36) [acx.class:?] at net.minecraft.item.ItemStack.func_77950_b(Unknown Source) [add.class:?] at net.minecraft.entity.player.EntityPlayer.func_71036_o(Unknown Source) [yz.class:?] at net.minecraft.entity.player.EntityPlayerMP.func_71036_o(EntityPlayerMP.java:1214) [mw.class:?] at net.minecraft.entity.player.EntityPlayer.func_70071_h_(Unknown Source) [yz.class:?] at net.minecraft.entity.player.EntityPlayerMP.localOnUpdateEntity(EntityPlayerMP.java:399) [mw.class:?] at api.player.server.ServerPlayerAPI.onUpdateEntity(ServerPlayerAPI.java:6146) [ServerPlayerAPI.class:?] at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java) [mw.class:?] at net.minecraft.network.NetHandlerPlayServer.func_147347_a(NetHandlerPlayServer.java:488) [nh.class:?] at net.minecraft.network.play.client.C03PacketPlayer.func_148833_a(C03PacketPlayer.java:36) [jd.class:?] at net.minecraft.network.play.client.C03PacketPlayer.func_148833_a(C03PacketPlayer.java:101) [jd.class:?] at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:245) [ej.class:?] at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:181) [nc.class:?] at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:1023) [MinecraftServer.class:?] at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:432) [lt.class:?] at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:841) [MinecraftServer.class:?] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:693) [MinecraftServer.class:?] at java.lang.Thread.run(Thread.java:750) [?:1.8.0_382]

@miozune miozune requested a review from a team August 24, 2023 01:43
Copy link

@Ethryan Ethryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but there was a lot of moved imports in this one.

@miozune
Copy link
Member Author

miozune commented Aug 24, 2023

yes, spotless config silently got changed at some point

@miozune miozune merged commit 1943028 into master Aug 25, 2023
1 check passed
@miozune miozune deleted the fix/foodstats-thermos branch August 25, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants