Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: [#334] GSMAuthenticationForm Feature μΆ”κ°€ #335

Merged
merged 1 commit into from
Jun 8, 2024
Merged

πŸ”€ :: [#334] GSMAuthenticationForm Feature μΆ”κ°€ #335

merged 1 commit into from
Jun 8, 2024

Conversation

baekteun
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

GSM Authentication Form Feature μΆ”κ°€

Resolves: #334

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • GSMAuthrnticationFormFeature λ₯Ό μΆ”κ°€ν–ˆμ–΄μš”
  • Interface, Implementations, Unit Tests, Demo λͺ¨λ“ˆμ„ 포함함

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

  • λͺ¨λ“ˆ μΆ”κ°€ ν›„ UI λΉŒλ”©ν•  수 있게 ν•΄μš”

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. .env, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "ν™˜κ²½κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@baekteun baekteun added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!! ✨ Feature μ‹ κ·œ κΈ°λŠ₯ labels May 26, 2024
@baekteun baekteun self-assigned this May 26, 2024
@baekteun baekteun linked an issue May 26, 2024 that may be closed by this pull request
인증제 Form UI μΆ”κ°€ #334
Closed
@baekteun baekteun force-pushed the 334-authentication-form-ui branch from 74f7118 to a218e68 Compare May 26, 2024 12:29
@baekteun baekteun force-pushed the 334-authentication-form-ui branch from a218e68 to bbef147 Compare May 28, 2024 16:09
@baekteun baekteun requested a review from kimsh153 May 30, 2024 06:05
@baekteun baekteun merged commit 9175ea7 into master Jun 8, 2024
2 checks passed
@baekteun baekteun deleted the 334-authentication-form-ui branch June 8, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uuuunseo uuuunseo uuuunseo approved these changes

@shwaaaa shwaaaa Awaiting requested review from shwaaaa shwaaaa is a code owner

@hanjaehyeong hanjaehyeong Awaiting requested review from hanjaehyeong hanjaehyeong is a code owner

@kimkyumbi kimkyumbi Awaiting requested review from kimkyumbi kimkyumbi is a code owner

@kimsh153 kimsh153 Awaiting requested review from kimsh153

Assignees

@baekteun baekteun

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!! ✨ Feature μ‹ κ·œ κΈ°λŠ₯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

인증제 Form UI μΆ”κ°€
2 participants
@baekteun @uuuunseo