Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: [#330] DesignSystem / FileField #331

Merged
merged 2 commits into from
May 30, 2024
Merged

๐Ÿ”€ :: [#330] DesignSystem / FileField #331

merged 2 commits into from
May 30, 2024

Conversation

kimsh153
Copy link
Member

@kimsh153 kimsh153 commented May 24, 2024 •
edited
Loading

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

FileField ์ œ์ž‘

2024-05-24.11.31.26.mov

Resolves: #330

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@kimsh153 kimsh153 self-assigned this May 24, 2024
baekteun
baekteun approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@baekteun baekteun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ  ์‹ค์ œ ์“ธ๋•Œ๊ฐ€ ๋ฐ”๋กœ ์“ฐ๋Š”๊ฑด ์•ˆ๋ ๊ฑฐ๊ฐ™๊ธดํ•˜๋„ค์š”

@baekteun
Copy link
Member

Action์— URL ๋„˜๊ธฐ๊ธฐ ใ„ฑใ„ฑ?

@kimsh153 kimsh153 force-pushed the 330-design-system-file-field branch from 95cf8ca to bd9df9d Compare May 24, 2024 14:53
@kimsh153 kimsh153 added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ labels May 24, 2024
@kimsh153 kimsh153 force-pushed the 330-design-system-file-field branch 2 times, most recently from e04d565 to b67e898 Compare May 30, 2024 16:01
@kimsh153 kimsh153 force-pushed the 330-design-system-file-field branch from b67e898 to 7a30fcc Compare May 30, 2024 16:02
@kimsh153 kimsh153 merged commit 14b7b5c into master May 30, 2024
2 checks passed
@kimsh153 kimsh153 deleted the 330-design-system-file-field branch May 30, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

@uuuunseo uuuunseo Awaiting requested review from uuuunseo uuuunseo is a code owner

@shwaaaa shwaaaa Awaiting requested review from shwaaaa shwaaaa is a code owner

@hanjaehyeong hanjaehyeong Awaiting requested review from hanjaehyeong hanjaehyeong is a code owner

@kimkyumbi kimkyumbi Awaiting requested review from kimkyumbi kimkyumbi is a code owner

Assignees

@kimsh153 kimsh153

Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โœจ Feature ์‹ ๊ทœ ๊ธฐ๋Šฅ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๋””์ž์ธ ์‹œ์Šคํ…œ FileField ์ถ”๊ฐ€
2 participants
@kimsh153 @baekteun