Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: [#326] DesignSystem / SMSSegmentedControl #327

Merged
merged 2 commits into from
May 26, 2024
Merged

๐Ÿ”€ :: [#326] DesignSystem / SMSSegmentedControl #327

merged 2 commits into from
May 26, 2024

Conversation

baekteun
Copy link
Member

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

Segmented Control ์ปดํฌ๋„ŒํŠธ๋ฅผ ์ถ”๊ฐ€ํ•ด์š”

2024-05-24.12.26.01.mov

Resolves: #326

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@baekteun baekteun linked an issue May 23, 2024 that may be closed by this pull request
๋””์ž์ธ ์‹œ์Šคํ…œ Segmented Control ์ถ”๊ฐ€ #326
Closed
@baekteun baekteun self-assigned this May 23, 2024
@baekteun baekteun added the 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! label May 23, 2024
@baekteun baekteun requested a review from kimsh153 May 23, 2024 15:27
kimsh153
kimsh153 approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@kimsh153 kimsh153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

baekteun and others added 2 commits May 26, 2024 21:02
@baekteun
๐Ÿ’„ :: [#326] DesignSystem / SMSSegmentedControl
7aa62ee
@baekteun @uuuunseo
Update SMSSegmentedControl.swift
9b4f07a 
Co-authored-by: uuuunseo <105629604+uuuunseo@users.noreply.github.com>
@baekteun baekteun force-pushed the 326-design-system-segmented-control branch from 099c8a9 to 9b4f07a Compare May 26, 2024 12:02
@baekteun baekteun merged commit 0f3eac4 into master May 26, 2024
2 checks passed
@baekteun baekteun deleted the 326-design-system-segmented-control branch May 26, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uuuunseo uuuunseo uuuunseo left review comments

@kimsh153 kimsh153 kimsh153 approved these changes

@shwaaaa shwaaaa Awaiting requested review from shwaaaa shwaaaa is a code owner

@hanjaehyeong hanjaehyeong Awaiting requested review from hanjaehyeong hanjaehyeong is a code owner

@kimkyumbi kimkyumbi Awaiting requested review from kimkyumbi kimkyumbi is a code owner

Assignees

@baekteun baekteun

Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๋””์ž์ธ ์‹œ์Šคํ…œ Segmented Control ์ถ”๊ฐ€
3 participants
@baekteun @kimsh153 @uuuunseo