๐ :: [#219] ์์ ์ ๋ณด ์ ๋ ฅ ์ถ๊ฐ #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
โฆinput-information-award
โฆinput-information-award
kimsh153
added
1๏ธโฃ Priority: High
baekteun
reviewed
Aug 2, 2023
baekteun
reviewed
Aug 2, 2023
Projects/Feature/InputProjectInfoFeature/Sources/Intent/InputProjectInfoIntent.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Aug 2, 2023
Projects/Feature/InputProjectInfoFeature/Interface/InputProjectInfoDelegate.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Aug 2, 2023
Projects/Feature/InputPrizeInfoFeature/Interface/InputPrizeDelegate.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Aug 2, 2023
Projects/Feature/InputPrizeInfoFeature/Interface/InputPrizeDelegate.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Aug 2, 2023
Projects/Feature/InputInformationFeature/Sources/Intent/InputInformationIntent.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Aug 2, 2023
Projects/Feature/InputPrizeInfoFeature/Interface/InputPrizeDelegate.swift
Outdated
Show resolved
Hide resolved
โฆegate.swift Co-authored-by: baegteun <baegteun@gmail.com>
kimsh153
commented
Aug 2, 2023
Projects/Feature/InputProjectInfoFeature/Interface/InputProjectInfoDelegate.swift
Outdated
Show resolved
Hide resolved
โฆtInfoDelegate.swift
baekteun
reviewed
Aug 2, 2023
Projects/Feature/InputPrizeInfoFeature/Sources/Scene/InputPrizeInfoView.swift
Outdated
Show resolved
Hide resolved
โฆeInfoView.swift Co-authored-by: baegteun <baegteun@gmail.com>
baekteun
reviewed
Aug 2, 2023
Projects/Feature/InputProjectInfoFeature/Sources/Intent/InputProjectInfoIntent.swift
Outdated
Show resolved
Hide resolved
โฆrojectInfoIntent.swift Co-authored-by: baegteun <baegteun@gmail.com>
baekteun
reviewed
Aug 2, 2023
Projects/Feature/InputInformationFeature/Sources/Intent/InputInformationIntent.swift
Outdated
Show resolved
Hide resolved
โฆnformationIntent.swift Co-authored-by: baegteun <baegteun@gmail.com>
baekteun
previously approved these changes
Aug 2, 2023
baekteun
reviewed
Aug 2, 2023
| @@ -16,6 +16,7 @@ let project = Project.makeModule( | |||
| .Shared.FoundationUtil, | |||
| .Shared.GlobalThirdPartyLibrary, | |||
| .Shared.Validator, | |||
| .Shared.UtilityModule | |||
| .Shared.UtilityModule, | |||
| .Shared.ConcurrencyUtil | |||
There was a problem hiding this comment.
์ ์ด๊ฑฐ BaseDomain์๋ ๋ฌ์๋๊ฒ GlobalThirdPartyLib์ผ๋ก ๋๊ธฐ๋๊ฑฐ ์ด๋์
โฆMSG/SMS-iOS into 219-input-information-award
baekteun
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก ๊ฐ์
์์ ์ ๋ณด ์ ๋ ฅ ์ถ๊ฐ
๐ ์์ ๋ด์ฉ
์์ ์ ๋ณด ์ ๋ ฅ ์ถ๊ฐ๋ฅผ ๋ง๋ค์์ต๋๋ค
๐ ๋ณ๊ฒฝ์ฌํญ
๐โโ๏ธ ์ง๋ฌธ์ฌํญ
์์ ์ข ๋ฅ๋ Prize๋ผ๊ณ ๋ช ํ๊ธด ํ๋๋ฐ ์ด๋ฆ์ PrizeType์ผ๋ก ๋ณ๊ฒฝ์ ํ๋๊ฒ ์ข์๊น์ ์๋๋ฉด ๋ค๋ฅธ ์ด๋ฆ์ ๋ณ๊ฒฝํด ์ฃผ๋๊ฒ ์ข์๊น์?
PrizeAt๋ ๋๊ฐ์ด DateAt์ผ๋ก ๋ณ๊ฒฝํ ์ง ๋ค๋ฅธ ์ด๋ฆ์ผ๋ก ๋ณ๊ฒฝํ ์ง ๊ณ ๋ฏผ์ ๋๋ค
๐ธ ๊ธฐํ
๐ธ