-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIGITAL-254: Guide content review #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update exported content for a non-HCD guide to facilitate review. * Fix summary field should be displayed in the header, not deck field * Removes reading time functionality for now * Remove extra div around body output * Add field for overview image to guide nav content type. * Display overview image in guide header. * Add credit and caption fields to image entities. * Display header attribution on guide pages * Enable glossary on HCD content * Add guide listing content type for HCD landing page * Migrate template for HCD landing page.
10 tasks
# Conflicts: # web/themes/custom/digital_gov/templates/node/node--guides.html.twig # web/themes/custom/digital_gov/templates/partials/guides/guide-content.html.twig
* Fix twig linting errors after merge with develop branch.
casey-rapnicki-bixal
force-pushed
the
develop
branch
3 times, most recently
from
January 16, 2025 22:53
21e91a1
to
7e47dca
Compare
casey-rapnicki-bixal
force-pushed
the
develop
branch
from
January 16, 2025 22:59
7e47dca
to
4a4650e
Compare
casey-rapnicki-bixal
force-pushed
the
develop
branch
from
January 16, 2025 23:57
4a4650e
to
78521e0
Compare
rayestrada
requested changes
Jan 17, 2025
web/themes/custom/digital_gov/templates/partials/guides/guide-content.html.twig
Outdated
Show resolved
Hide resolved
web/themes/custom/digital_gov/templates/partials/guides/guide-header.html.twig
Show resolved
Hide resolved
web/themes/custom/digital_gov/templates/partials/guides/guide-menu-bar.html.twig
Outdated
Show resolved
Hide resolved
- Don't render guide nav if the variable is empty. - Document where guide nav and glossary vars are set. - Remove extra closing div tag. - Handle if field_guide_nav_ref is not set (is null)
…4-guide-review # Conflicts: # terraform/applications/nginx-waf/nginx/conf.d/default.conf
rayestrada
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
DIGITAL-254
Purpose
Review of Drupal HTML against hugo generated markup.
Includes the following PRs that must be merged first
Deployment and testing
Local Setup
lando si
to get the default content with more built-out GuidesQA/Testing instructions
Checklist for the Developer
Checklist for the Peer Reviewers