Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIGITAL-254: Guide content review #128

Merged
merged 11 commits into from
Jan 17, 2025
Merged

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Jan 10, 2025

Jira ticket

DIGITAL-254

Purpose

Review of Drupal HTML against hugo generated markup.

  • Update exported content for a non-HCD guide to facilitate review.
  • Fix summary field should be displayed in the header, not deck field
  • Removes reading time functionality for now
  • Remove extra div around body output
  • Add field for overview image to guide nav content type.
  • Display overview image in guide header.
  • Add credit and caption fields to image entities.
  • Display header attribution on guide pages
  • Enable glossary on HCD content
  • Add guide listing content type for HCD landing page
  • Migrate template for HCD landing page.

Includes the following PRs that must be merged first

Deployment and testing

Local Setup

lando si to get the default content with more built-out Guides

QA/Testing instructions

  • Guide landing content type exists, with field for hero image, bottom html, glossary picker
  • Guide landing page HTML matches Hugo. Alias matches drupal.
  • Basic Guide pages match Hugo (without Reading Time, that'll come back later, maybe). Aliases match drupal.
  • HCD Guide pages and nav match Hugo. Aliases math drupal.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

* Update exported content for a non-HCD guide to facilitate review.
* Fix summary field should be displayed in the header, not deck field
* Removes reading time functionality for now
* Remove extra div around body output
* Add field for overview image to guide nav content type.
* Display overview image in guide header.
* Add credit and caption fields to image entities.
* Display header attribution on guide pages
* Enable glossary on HCD content
* Add guide listing content type for HCD landing page
* Migrate template for HCD landing page.
@omerida omerida requested a review from mattsqd January 10, 2025 17:30
# Conflicts:
#	web/themes/custom/digital_gov/templates/node/node--guides.html.twig
#	web/themes/custom/digital_gov/templates/partials/guides/guide-content.html.twig
* Fix twig linting errors after merge with develop branch.
@casey-rapnicki-bixal casey-rapnicki-bixal force-pushed the develop branch 3 times, most recently from 21e91a1 to 7e47dca Compare January 16, 2025 22:53
- Don't render guide nav if the variable is empty.
- Document where guide nav and glossary vars are set.
- Remove extra closing div tag.
- Handle if field_guide_nav_ref is not set (is null)
…4-guide-review

# Conflicts:
#	terraform/applications/nginx-waf/nginx/conf.d/default.conf
@rayestrada rayestrada merged commit 835517e into develop Jan 17, 2025
2 checks passed
@mattsqd mattsqd deleted the feature/DIGITAL-254-guide-review branch January 21, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants