Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Optimizations #6

Merged
merged 2 commits into from
May 8, 2023
Merged

Minor Optimizations #6

merged 2 commits into from
May 8, 2023

Conversation

nickumia-reisys
Copy link
Contributor

@nickumia-reisys nickumia-reisys commented Apr 28, 2023

Related to:

Changes:

References:

- I needed to specify the python version for poetry to work properly... I didn't have python 3.9 installed... python-poetry/poetry#1735 (comment)
- Don't limit python version to ^3.9, but we should support all newer version as well
- Add titles to make the Github Action page easier to read
@github-actions
Copy link

github-actions bot commented Apr 28, 2023

Coverage

Coverage Report
FileStmtsMissCover
datagovharvester/utils
   __init__.py00100%
   json_utilities.py40100%
datagovharvester/validate
   __init__.py00100%
   dcat_us.py200100%
TOTAL240100%

Tests Skipped Failures Errors Time
12 0 💤 0 ❌ 0 🔥 6.477s ⏱️

@nickumia-reisys nickumia-reisys marked this pull request as ready for review May 8, 2023 13:55
@nickumia-reisys nickumia-reisys requested a review from a team May 8, 2023 13:55
@nickumia-reisys
Copy link
Contributor Author

@btylerburton Can you update the "required" tests please? 🙃

@btylerburton btylerburton merged commit 8078c5b into main May 8, 2023
@btylerburton btylerburton deleted the minor-optimizations branch May 8, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants