This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Add domain whitelist #264
Merged
Add domain whitelist #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 18, 2018 22:38
- Added ALLOWED_DOMAINS for config object
seanstar12
pushed a commit
to seanstar12/code-gov-api
that referenced
this pull request
Aug 27, 2019
Add allowed domains to CORS middleware.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added allowed domains to CORS middleware configuration. This will stop malicious actors from probing our API and force users to go through api.data.gov.
Explain the motivation for making this change. What existing problem does the pull request solve?
We wanted to force our users to go through api.data.gov. Before this change they could bypass it if they knew about the route URL from Cloud.gov
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
All test passed:
