This repository has been archived by the owner on Dec 6, 2022. It is now read-only.
update: pull in upstream csb features #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, allow terraform code changes to be pulled in between brokerpak updates so new features can be added through an 'update-service'
nickumia-reisys
requested review from
mogul and
a team
and removed request for
mogul
FuhuXia
approved these changes
Apr 11, 2022
mogul
reviewed
Apr 11, 2022
| @@ -9,6 +9,10 @@ RUN apk upgrade | |||
| # Install git so we can use it to grab Terraform modules | |||
| RUN apk add --update git | |||
|
|
|||
| # Enable re-templates of Terraform Code | |||
| # Reference: https://github.com/GSA/data.gov/issues/3083 | |||
| ENV BROKERPAK_UPDATES_ENABLED true | |||
There was a problem hiding this comment.
Env vars related to how it gets configured should probably happen on the docker compose side, but since this is presumably going to come out from behind the feature-flag I'm OK with doing it here, so that for the consumers of the image, it's as if that already happened.
HOWEVER, remember that the production SSB deployment doesn't use this image, so we need to also set it up in the app deployments.
There was a problem hiding this comment.
Good point. I thought it was going to be a requirement for our operations for the foreseeable future, so it aligned with our other GSA customizations. But I agree that this is not a catch-all for our apps (unfortunately).
mogul
approved these changes
Apr 11, 2022
This was referenced Apr 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to GSA/data.gov#3083
Specifically, allow terraform code changes to be pulled in between brokerpak updates so new features can be added through an 'update-service'.