-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return conditional minify #509
base: staging
Are you sure you want to change the base?
Conversation
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ ACTION | actionlint | 4 | 0 | 0.07s | |
✅ BASH | shellcheck | 3 | 0 | 0.11s | |
✅ BASH | shfmt | 3 | 0 | 0 | 0.25s |
scss-lint | 2 | 1 | 4.09s | ||
✅ JAVASCRIPT | prettier | 13 | 0 | 0 | 1.55s |
✅ JSON | jsonlint | 7 | 0 | 0.24s | |
✅ JSON | npm-package-json-lint | yes | no | 0.46s | |
✅ JSON | prettier | 7 | 0 | 0 | 1.48s |
✅ JSON | v8r | 7 | 0 | 13.31s | |
markdownlint | 32 | 0 | 8 | 2.29s | |
✅ MARKDOWN | markdown-link-check | 32 | 0 | 15.67s | |
✅ MARKDOWN | markdown-table-formatter | 32 | 0 | 0 | 0.51s |
✅ REPOSITORY | checkov | yes | no | 14.57s | |
✅ REPOSITORY | gitleaks | yes | no | 0.39s | |
✅ REPOSITORY | git_diff | yes | no | 0.24s | |
✅ REPOSITORY | grype | yes | no | 14.94s | |
✅ REPOSITORY | secretlint | yes | no | 3.06s | |
✅ REPOSITORY | trivy | yes | no | 7.47s | |
✅ REPOSITORY | trivy-sbom | yes | no | 1.28s | |
✅ REPOSITORY | trufflehog | yes | no | 4.58s | |
cspell | 32 | 35 | 3.92s | ||
✅ YAML | prettier | 16 | 0 | 0 | 1.36s |
✅ YAML | v8r | 12 | 0 | 13.95s | |
✅ YAML | yamllint | 16 | 0 | 0.48s |
See detailed report in MegaLinter reports
Pa11y testing results```Running axe-core 4.8.4 in chrome-headlessTesting https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/404/ ... please wait, this may take a minute. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/SECURITY/ ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 3 occurrences! Violation of "document-title" with 1 occurrences! Violation of "html-has-lang" with 1 occurrences! 5 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/about/ ... please wait, this may take a minute. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/allstar/ ... please wait, this may take a minute. Violation of "document-title" with 1 occurrences! Violation of "html-has-lang" with 1 occurrences! 2 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/ ... please wait, this may take a minute. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/overview/ ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 1 occurrences! Violation of "document-title" with 1 occurrences! Violation of "html-has-lang" with 1 occurrences! 3 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/about-the-dha/ ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 8 occurrences! 8 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/compensation-and-benefits/ ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 4 occurrences! 4 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/faq/ ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 32 occurrences! 32 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/federal-job-posting/ ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 21 occurrences! 21 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/hiring-process/ ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 7 occurrences! 7 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/ ... please wait, this may take a minute. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/newsletter/ ... please wait, this may take a minute. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/cloud-gov-account-manager-business-lead.html ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 5 occurrences! 5 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/tts-platforms-and-services-communities-and-collaboration-branch-chief.html ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 5 occurrences! 5 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/tts-office-of-solutions-fedramp-security-director.html ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 2 occurrences! 2 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/tts-fellowships-office-presidential-innovation-fellows-director.html ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 2 occurrences! 2 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/public-experience-contact-center-analyst.html ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 5 occurrences! 5 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/public-experience-content-and-outreach-branch-chief.html ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 4 occurrences! 4 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/tts-fellowships-office-presidential-innovation-fellows.html ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 4 occurrences! 4 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/login-gov-data-engineer.html ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 5 occurrences! 5 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/login-gov-fraud-analyst.html ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 5 occurrences! 5 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/login-gov-data-analyst.html ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 5 occurrences! 5 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/tts-organizational-culture-development-specialist.html ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 5 occurrences! 5 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/join/resume/ ... please wait, this may take a minute. Violation of "aria-hidden-focus" with 7 occurrences! 7 Accessibility issues detected. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/services/ ... please wait, this may take a minute. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/services/people/ ... please wait, this may take a minute. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/services/platforms/ ... please wait, this may take a minute. Testing https://federalist-a2423046-fe43-4e75-a2ef-2651e5e123ca.sites.pages.cloud.gov/preview/gsa-tts/tts.gsa.gov/wesley-dean-gsa-patch-2/services/products/ ... please wait, this may take a minute. Please note that only 20% to 50% of all accessibility issues can automatically be detected.
|
Changes proposed in this pull request
Seeing that the minification dependencies are now in package.json, this readds the minification script
security considerations
None