Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/missing info intro #409

Merged
merged 14 commits into from
Sep 30, 2024
Merged

Fix/missing info intro #409

merged 14 commits into from
Sep 30, 2024

Conversation

ximekilgsa
Copy link
Contributor

  • Adds the missing info intro to job postings and template
  • Fixes the JS to show/hide info sessions to work by seconds vs milliseconds

@ximekilgsa ximekilgsa requested review from a team as code owners September 30, 2024 18:54
Copy link

github-actions bot commented Sep 30, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.05s
✅ BASH shellcheck 1 0 0.08s
✅ BASH shfmt 1 0 0 0.26s
⚠️ CSS scss-lint 2 1 3.84s
✅ JAVASCRIPT prettier 6 0 0 1.17s
✅ JSON jsonlint 7 0 0.2s
✅ JSON npm-package-json-lint yes no 0.47s
✅ JSON prettier 7 0 0 1.29s
✅ JSON v8r 7 0 10.18s
⚠️ MARKDOWN markdownlint 29 0 8 1.97s
✅ MARKDOWN markdown-link-check 29 0 17.72s
✅ MARKDOWN markdown-table-formatter 29 0 0 0.37s
✅ REPOSITORY checkov yes no 14.44s
✅ REPOSITORY gitleaks yes no 0.26s
✅ REPOSITORY git_diff yes no 0.22s
✅ REPOSITORY grype yes no 14.53s
✅ REPOSITORY secretlint yes no 2.63s
✅ REPOSITORY trivy yes no 8.22s
✅ REPOSITORY trivy-sbom yes no 1.1s
✅ REPOSITORY trufflehog yes no 4.19s
⚠️ SPELL cspell 29 26 3.85s
✅ YAML prettier 16 0 0 1.21s
✅ YAML v8r 12 0 12.59s
✅ YAML yamllint 16 0 0.44s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@wesley-dean-gsa wesley-dean-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just two tiny changes requested.

.eleventy.js Outdated Show resolved Hide resolved
_includes/layouts/jointts/job-listing-info-sessions.html Outdated Show resolved Hide resolved
Copy link
Contributor

@wesley-dean-gsa wesley-dean-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you very much.

@ximekilgsa ximekilgsa merged commit ff215ee into staging Sep 30, 2024
13 checks passed
@ximekilgsa ximekilgsa deleted the fix/missing-info-intro branch September 30, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants