Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/job template refinements #387

Merged
merged 25 commits into from
Sep 30, 2024
Merged

Conversation

ximekilgsa
Copy link
Contributor

Changes proposed in this pull request

  • Fixes some instructions for content editors
  • Creates template parts for open and upcoming listings
  • Adds new logic that displays info sessions based on date AND time, not just date
  • Adds JS to hide info sessions without needing a deployment, since they happen at different times.
  • Removes an undisplayed image with an incorrect path that was throwing an error in the console

security considerations

N/A

@ximekilgsa ximekilgsa requested review from a team as code owners September 26, 2024 13:57
Copy link

github-actions bot commented Sep 26, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.06s
✅ BASH shellcheck 1 0 0.08s
✅ BASH shfmt 1 0 0 0.24s
⚠️ CSS scss-lint 2 1 3.39s
✅ JAVASCRIPT prettier 6 0 0 1.17s
✅ JSON jsonlint 7 0 0.2s
✅ JSON npm-package-json-lint yes no 0.51s
✅ JSON prettier 7 0 0 1.32s
✅ JSON v8r 7 0 10.79s
⚠️ MARKDOWN markdownlint 29 0 8 1.9s
✅ MARKDOWN markdown-link-check 29 0 15.1s
✅ MARKDOWN markdown-table-formatter 29 0 0 0.37s
✅ REPOSITORY checkov yes no 15.09s
✅ REPOSITORY gitleaks yes no 0.3s
✅ REPOSITORY git_diff yes no 0.24s
✅ REPOSITORY grype yes no 13.51s
✅ REPOSITORY secretlint yes no 2.62s
⚠️ REPOSITORY trivy yes 1 1.3s
✅ REPOSITORY trivy-sbom yes no 1.07s
✅ REPOSITORY trufflehog yes no 4.01s
⚠️ SPELL cspell 29 26 4.42s
✅ YAML prettier 16 0 0 1.28s
✅ YAML v8r 12 0 14.04s
✅ YAML yamllint 16 0 0.52s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@wesley-dean-gsa wesley-dean-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged that we're supporting 12-hour, am/pm time so this isn't a drop-in replacement:

https://github.com/moment/luxon/blob/master/docs/parsing.md

@ximekilgsa ximekilgsa merged commit 8c1f60a into staging Sep 30, 2024
12 checks passed
@ximekilgsa ximekilgsa deleted the fix/job-template-refinements branch September 30, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants