Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add site-wide favicon from the JoinTTS site #128

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Add site-wide favicon from the JoinTTS site #128

merged 9 commits into from
Jul 30, 2024

Conversation

wesley-dean-gsa
Copy link
Contributor

Add a passThroughCopy to take stuff from _img/favicon folder and put them in the root of the built site.

Changes proposed in this pull request:

  1. add 11ty config
  2. add favicon image
  3. add HTML meta stuff

security considerations

n/a

@wesley-dean-gsa
Update .eleventy.js
c3629f9 
Add a passThroughCopy to take stuff from `_img/favicon` folder and put them in the root of the built site.
@wesley-dean-gsa
Add files via upload
f4357ea
@wesley-dean-gsa
Rename _img/jointts_favicon.ico to _img/favicon/favicon.ico
601eeda 
Do it right this time.
@wesley-dean-gsa
Update meta.html
04a900b 
Add the HTML to make the favicon thingee work. 🤞
@wesley-dean-gsa wesley-dean-gsa changed the title Update .eleventy.js Add site-wide favicon from the JoinTTS site Jul 30, 2024
@wesley-dean-gsa
Copy link
Contributor Author

Here's how we did it:

  1. put the file in _img/favicon/favicon.ico
  2. in the 11ty config, add a passthrough to copy the image from _img/favicon/favicon.ico to assets/favicon.ico
  3. in the meta.html file, add the usual tag, but with | url to.. urlify it

@wesley-dean-gsa wesley-dean-gsa marked this pull request as ready for review July 30, 2024 17:52
@wesley-dean-gsa
Copy link
Contributor Author

Screenshot_20240730_135231

See the flag icon in the tab menu and the path in the inspect sidebar

debjudy
debjudy approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@debjudy debjudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@wesley-dean-gsa wesley-dean-gsa merged commit 16efedd into main Jul 30, 2024
5 checks passed
@wesley-dean-gsa wesley-dean-gsa deleted the 079-favicon branch July 30, 2024 17:53
@wesley-dean-gsa wesley-dean-gsa linked an issue Jul 30, 2024 that may be closed by this pull request
Update site-wide Favicon #79
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debjudy debjudy debjudy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update site-wide Favicon
2 participants
@wesley-dean-gsa @debjudy