Moving response status check out of get_qualtrics_response

gdrive/export_api.py

@@ -73,6 +73,11 @@ async def survey_upload_response_task(request):
 
         log.info("Response found, beginning export.")
 
+        if response["status"] != "Complete":
+            raise error.ExportError(
+                f"Cannot upload incomplete survery response to raw completions spreadsheet: {request.responseId}"
+            )
+
         # By the time we get here, we can count on the response containing the demographic data
         # as it is included in the Completed flow responses. Responses without complete status
         # throws exception in get_qualtrics_response
@@ -117,7 +122,7 @@ class FindModel(BaseModel):
     responseId: str
     field: str
     values: list[str]
-    result_field: str | None
+    result_field: str | None = None
 
 
 @router.post("/find")

gdrive/export_client.py

@@ -170,11 +170,4 @@ def get_qualtrics_response(surveyId: str, responseId: str):
             f"No survey response found for responseId: {responseId}"
         )
 
-    resp = r.json()
-
-    if resp["status"] != "Complete":
-        raise error.ExportError(
-            f"Cannot upload incomplete survery response to raw completions spreadsheet: {responseId}"
-        )
-
-    return resp
+    return r.json()