Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic CI for Go CF Driver #71

Merged
merged 18 commits into from
Dec 18, 2024
Merged

Basic CI for Go CF Driver #71

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4826917
feat: add basic CI workflow for cf-driver-go
zjrgov Dec 18, 2024
3510063
fix: using the right file path would help
zjrgov Dec 18, 2024
85f52fb
fix: how about setting a working directory
zjrgov Dec 18, 2024
b1c99bd
feat: have the go fmt step check for diffs
zjrgov Dec 18, 2024
3c16241
chore: spec a go version in case GitHub likes that better
zjrgov Dec 18, 2024
7e6c192
chore: set a specific step to install deps
zjrgov Dec 18, 2024
3c637ee
fix: supply setup-go w/ go.sum path
zjrgov Dec 18, 2024
6f666d1
chore: test failing go fmt
zjrgov Dec 18, 2024
bbdf10e
fix: gofmt doesn't take the ./... style arg
zjrgov Dec 18, 2024
67eaca6
fix: foiled by quoting!
zjrgov Dec 18, 2024
ec49c7a
chore: fix the formatting
zjrgov Dec 18, 2024
9ced4bf
chore: validate that go vet will fail
zjrgov Dec 18, 2024
0accd99
chore: remove my go vet break
zjrgov Dec 18, 2024
9cc8c15
chore: add a bug to validate test failure
zjrgov Dec 18, 2024
2c63af9
Revert "chore: add a bug to validate test failure"
zjrgov Dec 18, 2024
d4171a9
feat: upgrade setup-go to v5
zjrgov Dec 18, 2024
c6be944
feat: get go version for action from go.mod
zjrgov Dec 18, 2024
ae11c97
chore: not necessary to pin a patch version for go
zjrgov Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cf-driver-go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: "1.23.x"
go-version-file: runner/cf-driver-go/go.mod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[praise] nice!

cache-dependency-path: runner/cf-driver-go/go.sum

- name: Install dependencies
Expand Down
Loading