Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPF records #5

Merged
merged 11 commits into from
Oct 26, 2021
Merged

Add SPF records #5

merged 11 commits into from
Oct 26, 2021

Conversation

nickumia-reisys
Copy link
Contributor

Related to GSA/data.gov#3301

@nickumia-reisys nickumia-reisys marked this pull request as ready for review October 26, 2021 22:12
@nickumia-reisys
Copy link
Contributor Author

Important Upgrades:

  • Build brokerpak as normal user, so that privileges are not needed to delete it.
  • Add SPF record for route53 domain that sends mail, if no domain specified
  • Add output of SPF record for user to implement in their domain configuration, if domain is specified
  • Fix Bind argument for unique IAM role configuration
  • Add validation test to ensure SPF record exists for AWS-specific domain configuration

Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me!

@jbrown-xentity jbrown-xentity mentioned this pull request Oct 26, 2021
@nickumia-reisys nickumia-reisys merged commit cc59da4 into main Oct 26, 2021
@nickumia-reisys nickumia-reisys deleted the add-spf-records branch October 26, 2021 22:56
@@ -73,7 +73,7 @@ provision:
details: AWS region for the SES instance
- field_name: dkim_records
type: object
details: If a domain was supplied DKIM records to be created
details: If a domain was supplied DKIM, records to be created
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that comma where it should be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants