Change Coverage Reporting Tool

[asteel-gsa]

The other major coverage tools output too much to the PR, and make it difficult to use for Review.
cobertura-report has an outstanding issue with displaying modified files, as well as broke when the merge occurs due to this. It did not break when it output the entire coverage report to the PR
code-coverage-report-action while nice to have a diff on old coverage reports, outputs everything as if it were on the docker container and has no ability to hide 100% items.

The new action, while it doesnt display line numbers, gives the reviewer easy access to bring the testing up to 90% threshold, while keeping the pr clean.

[github-actions]

Terraform plan for meta

No changes. Your infrastructure matches the configuration.

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.s3-backups.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/s3-backups/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

✅ Plan applied in Deploy to Development and Management Environment #838

[github-actions]

Terraform plan for dev

Plan: 1 to add, 2 to change, 1 to destroy.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.dev.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
!~  resource "cloudfoundry_app" "clamav_api" {
!~      docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:8119bc9c23555b7331108f0cf918cabb3303c7b44eb382aadc7a352222eb532c" -> "ghcr.io/gsa-tts/fac/clamav@sha256:9f2daecce2d94248952899f82133dee8018cc0a03a7f5330b8013b69468344a4"
        id                              = "779bbc51-f78a-4186-90eb-5acb68d7d746"
        name                            = "fac-av-dev"
#        (17 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

  # module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2024-08-17T00:33:18Z" -> (known after apply)
        }
    }

  # module.dev.module.file_scanner_clamav.cloudfoundry_app.clamav_api will be updated in-place
!~  resource "cloudfoundry_app" "clamav_api" {
!~      docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:8119bc9c23555b7331108f0cf918cabb3303c7b44eb382aadc7a352222eb532c" -> "ghcr.io/gsa-tts/fac/clamav@sha256:9f2daecce2d94248952899f82133dee8018cc0a03a7f5330b8013b69468344a4"
        id                              = "65c83416-4126-4785-99c2-5e1adb810422"
        name                            = "fac-av-dev-fs"
#        (17 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

Plan: 1 to add, 2 to change, 1 to destroy.

Warning: Argument is deprecated

  with module.dev-backups-bucket.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/dev-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 6 more similar warnings elsewhere)

❌ Plan not applied in Deploy to Development and Management Environment #838 (Plan has changed)

[asteel-gsa]

@danswick What do you think of these thresholds for the new coverage report?

[asteel-gsa]

Still unsure if the team is feeling the coverage necessity at this time. Thread on options here

[github-actions]

Package	Line Rate	Branch Rate	Health
.	100%	100%	✔
api	98%	92%	✔
audit	97%	92%	✔
audit.cross_validation	98%	89%	✔
audit.fixtures	84%	43%	❌
audit.intakelib	94%	84%	➖
audit.intakelib.checks	95%	89%	✔
audit.intakelib.common	98%	83%	✔
audit.intakelib.transforms	99%	97%	✔
audit.management.commands	78%	17%	❌
audit.migrations	100%	100%	✔
audit.models	95%	83%	➖
audit.templatetags	100%	100%	✔
audit.views	60%	45%	❌
census_historical_migration	96%	93%	✔
census_historical_migration.migrations	100%	100%	✔
census_historical_migration.sac_general_lib	92%	85%	➖
census_historical_migration.transforms	95%	90%	✔
census_historical_migration.workbooklib	68%	66%	❌
config	81%	12%	❌
dissemination	93%	84%	➖
dissemination.migrations	97%	25%	✔
dissemination.searchlib	74%	59%	❌
dissemination.templatetags	100%	100%	✔
djangooidc	53%	38%	❌
djangooidc.tests	100%	97%	✔
report_submission	93%	90%	➖
report_submission.migrations	100%	100%	✔
report_submission.templatetags	74%	100%	❌
support	95%	83%	✔
support.management.commands	96%	100%	✔
support.migrations	100%	100%	✔
support.models	97%	83%	✔
tools	98%	83%	✔
users	98%	100%	✔
users.fixtures	100%	83%	✔
users.management	100%	100%	✔
users.management.commands	100%	100%	✔
users.migrations	100%	100%	✔
Summary	91% (16568 / 18150)	83% (3183 / 3838)	➖

[jadudm]

LGTM. And, if we want to change it/go back, we can.