Skip to content

Commit

Permalink
Tweaking audit user management instructions (#4382)
Browse files Browse the repository at this point in the history
* Allowing users to remove editors

* Better handling for users removing their own access

* User management documentation

* Lint

* Lint

* Unit tests

* Lint

* Lint

* More 404 tests

* Only editors can remove an editor

* Moving RemoveEditorViewTests to its own file

* Lint

* Fixing test

* Fixing Remove column

* Test cleanup

* Lint

* Audit metadata fix

* Fixing unit tests

* Updating instructions

* Tweaking instructions
  • Loading branch information
phildominguez-gsa authored Oct 15, 2024
1 parent 5c80211 commit 5d66f8a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions backend/audit/templates/audit/manage-submission.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ <h1 class="usa-legend usa-legend--large font-sans-2xl">Manage user roles</h1>
<div class="font-sans-md margin-y-4">
<p>The table below lists the individuals with access to this single audit submission.</p>
<p>
There may only be one Auditee Certifying Official and one Auditor Certifying Official. These users must have different email addresses. Any substitution for these roles will remove the prior user.
There must only be one Auditee Certifying Official and one Auditor Certifying Official. These users must have different email addresses. Any substitution for these roles will remove the prior user.
</p>
{% comment %}
Uncomment when we can add/remove other types of editors.
Expand All @@ -36,7 +36,7 @@ <h1 class="usa-legend usa-legend--large font-sans-2xl">Manage user roles</h1>
</p>
{% endcomment %}
<p>
To change an individual's role, click the "edit" link in the table. At this time, you may only change the certifying officials and this may only be done by the Audit Editor.
To change an individual's role, click the “Edit” link in the table. At this time, you can only change the certifying officials, and this can only be done by an Audit Editor.
</p>
<p>
It's recommended that larger organizations always add at least two of their staff in the Audit Editor role. This ensures that an audit does not become inaccessible due to the departure of a staff member.
Expand Down
2 changes: 1 addition & 1 deletion backend/audit/templates/audit/remove-editor-access.html
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ <h1 id="role-management">Remove Editor</h1>

{% if is_editor_removing_self %}
<p class="font-sans-md">
Editors do not have permission to remove their own access.
Audit Editors cannot remove their own access. This helps to ensure that an audit remains accessible to an organization.
</p>
{% endif %}

Expand Down

0 comments on commit 5d66f8a

Please sign in to comment.